Updating sql connector version and testing integration with OAuth #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benc-db
requested review from
andrefurlan-db,
susodapop and
rcypher-databricks
as code owners
rcypher-databricks
previously approved these changes
Sep 6, 2023
susodapop
previously approved these changes
Sep 6, 2023
requirements.txt
Outdated
| @@ -1,4 +1,4 @@ | |||
| databricks-sql-connector~=2.7.0 | |||
| databricks-sql-connector>=2.7.0 | |||
There was a problem hiding this comment.
Any reason not to simply pin to the latest connector version? I'm okay with a wider specification, but it might be nicer to just hard-code to the latest and greatest.
There was a problem hiding this comment.
The only issue is keeping them in sync. Per our discussion this morning, I'm ok updating to >= 2.9.3, <3. If you make optional improvements in databricks-sql-connector, I don't want to force this project to have a release just to get access to them.
benc-db
dismissed stale reviews from susodapop and rcypher-databricks
via
8da0065
benc-db
force-pushed
the
sql-connector-version
branch
from
dd9ed06 to
8da0065
Compare
rcypher-databricks
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially aimed to resolve #433 and #410, but now believe there was a different issue at play there.
Description
Updates the databricks-sql-connector version. Initially I updated the version to >=2.9.0, but upon further testing, I didn't actually find an issue with 2.7.0. However, our previous version spec did not allow 2.9.x, which seems like an oversight.
Updates our integration test suite on Github Actions to use OAuth rather than token. As we are advertising that the connector supports this feature and that it is safer than using a PAT, we gain more by dogfooding with OAuth than continuing to test only PAT.
Updates the workflow README to inform users that jobs clusters are no longer supported for dbt tasks in Databricks Workflows (and haven't been for several months at least).
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.